Discussion:
[patch 7/8] USB testing driver: don't free a locked mutex
a***@linux-foundation.org
2007-12-14 00:15:34 UTC
Permalink
From: Andrew Morton <***@linux-foundation.org>

Dopey thing to do and lockdep will (or should) warn.

Spotted by Daniel Walker.

Cc: Matthias Kaehlcke <***@gmail.com>
Cc: Daniel Walker <***@mvista.com>
Cc: Greg KH <***@kroah.com>
Cc: Ingo Molnar <***@elte.hu>
Signed-off-by: Andrew Morton <***@linux-foundation.org>
---

drivers/usb/misc/usbtest.c | 2 --
1 file changed, 2 deletions(-)

diff -puN drivers/usb/misc/usbtest.c~usb-testing-driver-dont-free-a-locked-mutex drivers/usb/misc/usbtest.c
--- a/drivers/usb/misc/usbtest.c~usb-testing-driver-dont-free-a-locked-mutex
+++ a/drivers/usb/misc/usbtest.c
@@ -1991,8 +1991,6 @@ static void usbtest_disconnect (struct u
{
struct usbtest_dev *dev = usb_get_intfdata (intf);

- mutex_lock(&dev->lock);
-
usb_set_intfdata (intf, NULL);
dev_dbg (&intf->dev, "disconnect\n");
kfree (dev);
_

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
linux-usb-***@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Loading...