USB: sierra: Very small patch for Sierra Wireless AirCard 881 U (AT&T USBConnect 881)

Discussion:

j***@twu.net

2007-12-16 04:57:27 UTC

Hello all:

Yesterday, I obtained an AT&T-badged Sierra Wireless AirCard 881U
(a.k.a. USBConnect 881). The vendor ID is 0x1199 and the product ID is
0x6856. A trivial two-line addition was needed to the sierra.c source
provided with the 2.6.23 kernel. The patch is below, and attached as well.

======================= snip =============================================
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

======================= snip =============================================

Please see that this change makes it into the driver so that
others can use this device without hacking kernel sources. ;)

Many thanks,

--Jessica

j***@twu.net

2007-12-16 23:43:36 UTC

Permalink

Hello all:

Yesterday, I obtained an AT&T-badged Sierra Wireless AirCard 881U
(a.k.a. USBConnect 881). The vendor ID is 0x1199 and the product ID is 0x6856.
A trivial two-line addition was needed to the sierra.c source provided with the
2.6.23 kernel. The patch is below, and attached as well.

======================= snip =============================================
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

======================= snip =============================================

Please see that this change makes it into the driver so that others can
use this device without hacking kernel sources. ;)

Many thanks,

--Jessica

Marcel Holtmann

2007-12-17 01:19:13 UTC

Permalink

Hi Jessica,

Post by j***@twu.net
Yesterday, I obtained an AT&T-badged Sierra Wireless AirCard 881U
(a.k.a. USBConnect 881). The vendor ID is 0x1199 and the product ID is 0x6856.
A trivial two-line addition was needed to the sierra.c source provided with the
2.6.23 kernel. The patch is below, and attached as well.
======================= snip =============================================
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

======================= snip =============================================
Please see that this change makes it into the driver so that others can
use this device without hacking kernel sources. ;)

the file Documentation/SubmittingPatches contains a guide on how to
submit kernel patches the proper way. This also applies to patch for the
USB subsystem.

In short, the minimum is using unified diffs (-u switch) and providing a
Signed-off-by line besides the description that you already have in this
email.

Regards

Marcel

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
linux-usb-***@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Greg KH

2007-12-21 21:04:39 UTC

Permalink

Yesterday, I obtained an AT&T-badged Sierra Wireless AirCard 881U (a.k.a.
USBConnect 881). The vendor ID is 0x1199 and the product ID is 0x6856. A
trivial two-line addition was needed to the sierra.c source provided with
the 2.6.23 kernel. The patch is below, and attached as well.
======================= snip =============================================
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

======================= snip =============================================
Please see that this change makes it into the driver so that others can
use this device without hacking kernel sources. ;)
Many thanks,
--Jessica
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

Can you resend this as per the directions in
Documentation/SubmittingPatches so that I can properly appy it to the
linux kernel source tree?

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-***@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

j***@twu.net

2007-12-21 21:26:23 UTC

Permalink

Will do.

Post by Greg KH

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

======================= snip =============================================
Please see that this change makes it into the driver so that others can
use this device without hacking kernel sources. ;)
Many thanks,
--Jessica
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

Can you resend this as per the directions in
Documentation/SubmittingPatches so that I can properly appy it to the
linux kernel source tree?
thanks,
greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-***@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

j***@twu.net

2007-12-24 05:14:18 UTC

Permalink

Attached and below, please find the output of 'diff -up' for this patch.
All this patch does is add support for the Sierra Wireless AirCard 881 U
(which is now what AT&T is selling at their stores as their sole USB 3G
device).

===================================snip======================================
--- sierra.c 2007-10-09 16:31:38.000000000 -0400
+++ /root/sierra.c 2007-12-24 08:11:32.000000000 -0500
@@ -115,6 +115,7 @@ static struct usb_device_id id_table []
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880 E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881 E */
+ { USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

{ USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /* Sierra Wireless AirCard 580 */
{ USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /* Airprime/Sierra PC 5220 */
@@ -151,6 +152,7 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881E */
+ { USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */
{ }
};

===================================snip======================================

Post by Greg KH

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

======================= snip =============================================
Please see that this change makes it into the driver so that others can
use this device without hacking kernel sources. ;)
Many thanks,
--Jessica
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

Can you resend this as per the directions in
Documentation/SubmittingPatches so that I can properly appy it to the
linux kernel source tree?
thanks,
greg k-h

Greg KH

2007-12-24 05:46:45 UTC

Permalink

Post by j***@twu.net
Attached and below, please find the output of 'diff -up' for this patch.
All this patch does is add support for the Sierra Wireless AirCard 881 U
(which is now what AT&T is selling at their stores as their sole USB 3G
device).
===================================snip======================================
--- sierra.c 2007-10-09 16:31:38.000000000 -0400
+++ /root/sierra.c 2007-12-24 08:11:32.000000000 -0500

Can you redo this so I can apply it based at the root of the kernel
tree, and add a "Signed-off-by:" line, and fix your email client so it
doesn't turn tabs into spaces so the patch can be applied?

The SubmittingPatches file should show how to do this all this way...

thanks,

greg k-h

Post by j***@twu.net
@@ -115,6 +115,7 @@ static struct usb_device_id id_table []
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880 E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881 E */
+ { USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */
{ USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /* Sierra
Wireless AirCard 580 */
{ USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /*
Airprime/Sierra PC 5220 */
@@ -151,6 +152,7 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881E */
+ { USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */
{ }
};
===================================snip======================================

Post by Greg KH

Yesterday, I obtained an AT&T-badged Sierra Wireless AirCard 881U (a.k.a.
USBConnect 881). The vendor ID is 0x1199 and the product ID is 0x6856. A
trivial two-line addition was needed to the sierra.c source provided with
the 2.6.23 kernel. The patch is below, and attached as well.
======================= snip
=============================================
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

======================= snip
=============================================
Please see that this change makes it into the driver so that others can
use this device without hacking kernel sources. ;)
Many thanks,
--Jessica
117a118

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

153a155

{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */

Can you resend this as per the directions in
Documentation/SubmittingPatches so that I can properly appy it to the
linux kernel source tree?
thanks,
greg k-h

--- sierra.c 2007-10-09 16:31:38.000000000 -0400
+++ /root/sierra.c 2007-12-24 08:11:32.000000000 -0500
@@ -115,6 +115,7 @@ static struct usb_device_id id_table []
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880 E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881 E */
+ { USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */
{ USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /* Sierra Wireless AirCard 580 */
{ USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /* Airprime/Sierra PC 5220 */
@@ -151,6 +152,7 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881E */
+ { USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */
{ }
};

j***@twu.net

2007-12-31 02:11:35 UTC

Permalink

from Jessica L. Blank <***@twu.net:>

Adds the appropriate vendor and device IDs for the AirCard 881U to
sierra.c. (This device is often rebadged by AT&T as the USBConnect 881).
Signed-off-by: Jessica L Blank <***@twu.net>
---
--- /usr/src/linux-2.6.23/drivers/usb/serial/sierra.c.orig 2007-10-09 16:31:38.000000000 -0400
+++ /usr/src/linux-2.6.23/drivers/usb/serial/sierra.c 2007-12-31 05:10:03.000000000 -0500
@@ -115,6 +115,7 @@ static struct usb_device_id id_table []
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880 E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881 E */
+ { USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */

{ USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /* Sierra Wireless AirCard 580 */
{ USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /* Airprime/Sierra PC 5220 */
@@ -151,6 +152,7 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881E */
+ { USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */
{ }
};

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-***@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel